search

rubin-dp0 / tutorial-notebooks

Tutorial Jupyter Notebooks for Data Preview 0, created and maintained by the Rubin Observatory Community Science Team.
Apache License 2.0
33 stars 17 forks source link

tickets/PREOPS-4856 #171

Closed christinawilliams closed 5 months ago

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jeffcarlin commented 7 months ago

Overall I like how you've organized the notebook, but it seems like it might be hard for a user to understand how the cutout service works from this. It may need a little more explanation in Section 2.2.

The LBG example is cool! It's a little frustrating how long it takes for cells to execute, but I know that's out of our control...

The variable/transient example is good, but it may be useful to give a little more context. It is an abrupt change from the LBG to the variable, so I'd try to clarify as much as possible.

christinawilliams commented 5 months ago

I guess the plan is for this demonstration to be preceded by a more technical notebook that demonstrates the more technical details of the cutout service. Leanne is working on this, so hopefully in the future the pair of notebooks will together do a better job.