rubin-dp0 / tutorial-notebooks

Tutorial Jupyter Notebooks for Data Preview 0, created and maintained by the Rubin Observatory Community Science Team.
Apache License 2.0
33 stars 17 forks source link

tickets/PREOPS-1134: NB 03a #69

Closed kadrlica closed 2 years ago

kadrlica commented 2 years ago

This is a PR for the new notebook 03a on image display and manipulation using afwDisplay.

kadrlica commented 2 years ago

@DouglasLeeTucker would you be willing to trade notebooks for review?

DouglasLeeTucker commented 2 years ago

Yes! But I still need to do some updates on NB05 before it is ready to review again. Thanks!

From: Alex Drlica-Wagner @.> Date: Friday, June 17, 2022 at 9:40 AM To: rubin-dp0/tutorial-notebooks @.> Cc: Douglas L Tucker @.>, Mention @.> Subject: Re: [rubin-dp0/tutorial-notebooks] Notebook 03a (PR #69)

@DouglasLeeTuckerhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DouglasLeeTucker&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQy0X_wNb9wJndrdxKYoMiA&m=IH0L_Co9OBPdFFJIg-0mjAcJ1VqRTVyug84L9rPQPzWST7tIdlJM4KGKuhwvjGvC&s=demgcQbbaMwyXCnAsnQMVPEtcFo5F5daBRc8ivktt6s&e= would you be willing to trade notebooks for review?

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rubin-2Ddp0_tutorial-2Dnotebooks_pull_69-23issuecomment-2D1158939324&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQy0X_wNb9wJndrdxKYoMiA&m=IH0L_Co9OBPdFFJIg-0mjAcJ1VqRTVyug84L9rPQPzWST7tIdlJM4KGKuhwvjGvC&s=G-9LymszpQjQYlR4BSRDxzFy7wzBkE0glTM0HuJNmF0&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AARAHOIYTYUG5J4MK3JSJBLVPSE6JANCNFSM5ZCP3DXQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQy0X_wNb9wJndrdxKYoMiA&m=IH0L_Co9OBPdFFJIg-0mjAcJ1VqRTVyug84L9rPQPzWST7tIdlJM4KGKuhwvjGvC&s=T7AIJqLV8rxkkp-cuQU5NT7bVhOGV8RXnTTR9AeHtRw&e=. You are receiving this because you were mentioned.Message ID: @.***>

kadrlica commented 2 years ago

This should run "as is" on [data-int](https://data-int.lsst.cloud/) and it should also run on [data](https://data.lsst.cloud/) if you replace config='dp02' with config='dp02-test'.

DouglasLeeTucker commented 2 years ago

I've reviewed the updated notebook, and it looks good! I particularly like the inclusion of anchor points to link back to functions that were defined earlier in the notebook (e.g., for cutout_coadd and for create_rgb.

I just found 3 minor errors and typos:

  1. It looks like the Packages cell at the beginning of the notebook has not yet been updated.
  2. Under the Get Support cell at the beginning of the notebook, there is an old link to dp0-1.lsst.io (https://dp0-1.lsst.io/) that should be updated to dp0-2.lsst.io (https://dp0-2.lsst.io/).
  3. In Section 5, paragraph 5, the final sentence, there is a typo (“tutuorials” --> “tutorials”).

Other than those very minor issues, looks great!

DouglasLeeTucker commented 2 years ago

I also just now confirmed that the notebook NB03a works on data.lsst.cloud if one just changes config from dp02 to dp02-test.

kadrlica commented 2 years ago

Thanks @DouglasLeeTucker. I've corrected the issues that you identified and marked this PR as "Ready for Review". Could you sign off on it?