search

rubinius / rubinius

The Rubinius Language Platform
https://rubinius.com
Mozilla Public License 2.0
3.06k stars 602 forks source link

Bignum::from() seems to need a hint when using libtommath VERSION=0.41 on aarch64 #3818

Closed medols closed 4 years ago

medols commented 4 years ago

Thank you for taking the time to submit a pull-request to Rubinius. We appreciate your contribution.

Please respond to the following questions to help us merge your pull-request. Please leave the form contents in place. If a question isn't relevant, please respond with N/A.

  1. Is this pull-request complete?

    • [x] Yes, this pull-request is ready to be reviewed and merged.
    • [ ] No, this pull-request is a work-in-progress.

  2. Does this pull request fix an issue with an existing feature or introduce a new feature?

    • [x] It fixes an issue with an existing features.
    • [ ] It introduces a new feature.

  3. Does this pull-request include tests?

    • [ ] Yes, it includes tests.
    • [x] No, it does not include tests because the tests already exist.
    • [ ] No, it does not include tests because tests are too difficult to write.
    • [ ] No, it does not include tests because ...
brixen commented 4 years ago

@medols thanks for working on this! Should we wrap the (long long) cast into the C macro? Perhaps with some conditionals to make it platform specific?

brixen commented 4 years ago

@medols actually, since Rubinius VM is only 64bit now, these should be int64_t.

brixen commented 4 years ago

@medols thanks!