search

rubisco-sfa / ILAMB-Data

A collection of scripts used to format ILAMB data and community portal to make contributions
9 stars 3 forks source link

CERES Albedo has wrong unit #38

Closed nocollier closed 2 years ago

nocollier commented 2 years ago

Shouldn't this line:

https://github.com/mmu2019/Datasets/blob/master/read-albedo-ceres.py#L164

be 1?

mmu2019 commented 2 years ago

This code has been updated, but I tried to push the code and update the new file, but the request was denied.

nocollier commented 2 years ago

Ok, thanks. I can do it, I just wanted to make sure that I didn't misunderstand something.

On Mon, Sep 19, 2022 at 1:22 PM Mingquan Mu @.***> wrote:

This code has been updated, but I tried to push the code and update the new file, but the request was denied.

— Reply to this email directly, view it on GitHub https://github.com/rubisco-sfa/ILAMB-Data/issues/38#issuecomment-1251318247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFCBYD67IWTTSWGUGMM5TV7COM3ANCNFSM6AAAAAAQQF6WQM . You are receiving this because you authored the thread.Message ID: @.***>

mmu2019 commented 2 years ago

Great. Thanks.

Mingquan

On Mon, Sep 19, 2022 at 10:29 AM nocollier @.***> wrote:

Ok, thanks. I can do it, I just wanted to make sure that I didn't misunderstand something.

On Mon, Sep 19, 2022 at 1:22 PM Mingquan Mu @.***> wrote:

This code has been updated, but I tried to push the code and update the new file, but the request was denied.

— Reply to this email directly, view it on GitHub < https://github.com/rubisco-sfa/ILAMB-Data/issues/38#issuecomment-1251318247> https://urldefense.com/v3/__https://github.com/rubisco-sfa/ILAMB-Data/issues/38*issuecomment-1251318247*3E__;IyU!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uWEg3NNl$ , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAKFCBYD67IWTTSWGUGMM5TV7COM3ANCNFSM6AAAAAAQQF6WQM> https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAKFCBYD67IWTTSWGUGMM5TV7COM3ANCNFSM6AAAAAAQQF6WQM*3E__;JQ!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uQ8X2ERU$ . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/rubisco-sfa/ILAMB-Data/issues/38*issuecomment-1251325310__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uSD7Ve0a$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AMALL5DET6GKGYNN4HPFTCDV7CPGZANCNFSM6AAAAAAQQF6WQM__;!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uYhaF020$ . You are receiving this because you were assigned.Message ID: @.***>

nocollier commented 2 years ago

Looking at this some more, I went to check out the original data. I am seeing that they have 3 kinds of fluxes:

From your file I cannot tell which ones you used. Here is a talk they presented on the differences but it isn't completely clear to me which ones we should use. Do you know? Or should we bring this up to the group?

https://ceres.larc.nasa.gov/documents/STM/2019-05/12_Loeb_EBAF_Talk_Spring2019.pdf

On Mon, Sep 19, 2022 at 1:37 PM Mingquan Mu @.***> wrote:

Great. Thanks.

Mingquan

On Mon, Sep 19, 2022 at 10:29 AM nocollier @.***> wrote:

Ok, thanks. I can do it, I just wanted to make sure that I didn't misunderstand something.

On Mon, Sep 19, 2022 at 1:22 PM Mingquan Mu @.***> wrote:

This code has been updated, but I tried to push the code and update the new file, but the request was denied.

— Reply to this email directly, view it on GitHub <

https://github.com/rubisco-sfa/ILAMB-Data/issues/38#issuecomment-1251318247

< https://urldefense.com/v3/__https://github.com/rubisco-sfa/ILAMB-Data/issues/38*issuecomment-1251318247*3E__;IyU!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uWEg3NNl$

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAKFCBYD67IWTTSWGUGMM5TV7COM3ANCNFSM6AAAAAAQQF6WQM

< https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAKFCBYD67IWTTSWGUGMM5TV7COM3ANCNFSM6AAAAAAQQF6WQM*3E__;JQ!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uQ8X2ERU$

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://urldefense.com/v3/__https://github.com/rubisco-sfa/ILAMB-Data/issues/38*issuecomment-1251325310__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uSD7Ve0a$ , or unsubscribe < https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AMALL5DET6GKGYNN4HPFTCDV7CPGZANCNFSM6AAAAAAQQF6WQM__;!!CzAuKJ42GuquVTTmVmPViYEvSg!IosLLL0_fF_4AeIKwDiHIEWvihWV7lRQzKeZSoMj2fxdVgDpDo_-4x51orABRgatvO8G4CfsO1P6uYhaF020$

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rubisco-sfa/ILAMB-Data/issues/38#issuecomment-1251334281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFCBZUFV2UN4M6P2QJFG3V7CQGPANCNFSM6AAAAAAQQF6WQM . You are receiving this because you authored the thread.Message ID: @.***>

nocollier commented 2 years ago

See comparison plots here. The plot labeled 'ILAMB' is what we currently have which seems to be very nearly 'AllSky'. The other two options are close to each other but present a non-trivial bias. Which is more fair to models?

mmu2019 commented 2 years ago

Lines 24 and 25 have mentioned the radiation used is for all sky. Yes, you are right, and we should make it comparable to the models. Thanks to let me know.

nocollier commented 2 years ago

Thanks Mingquan, are you saying though that the 'All Sky' is the appropriate quantity to compare against models? Sorry if I am being a little dense, I do not understand all of these issues.

mmu2019 commented 2 years ago

Yes, I think model radiation data is for all sky.

On Mon, Sep 19, 2022 at 12:39 PM nocollier @.***> wrote:

Thanks Mingquan, are you saying though that the 'All Sky' is the appropriate quantity to compare against models? Sorry if I am being a little dense, I do not understand all of these issues.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/rubisco-sfa/ILAMB-Data/issues/38*issuecomment-1251466247__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!NUbQkJoq1p3zL2CsMtS9R_33X_YFSfYFc4XFV7oRlLRN4uqJdaTuslziCQLnk1-hzLfqgSfmaH0cHFcwxRmu$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AMALL5FKSBCFT4CXAVQXW2DV7C6QBANCNFSM6AAAAAAQQF6WQM__;!!CzAuKJ42GuquVTTmVmPViYEvSg!NUbQkJoq1p3zL2CsMtS9R_33X_YFSfYFc4XFV7oRlLRN4uqJdaTuslziCQLnk1-hzLfqgSfmaH0cHNJ9_2AU$ . You are receiving this because you were assigned.Message ID: @.***>