rubisco-sfa / ILAMB

Python software used in the International Land Model Benchmarking (ILAMB) project
BSD 3-Clause "New" or "Revised" License
46 stars 37 forks source link

Errors associated with FLUXCOM/reco.nc and FLUXCOM/gpp.nc #89

Open olyson opened 9 months ago

olyson commented 9 months ago

I'm getting errors associated with new versions of FLUXCOM/reco.nc and FLUXCOM/gpp.nc datasets. I see that the reco and gpp variables in these files are ordered (lat,lon,time) instead of (time,lat,lon), e.g.,

    float gpp(lat, lon, time) ;
            gpp:_FillValue = nanf ;
            gpp:long_name = "GPP" ;
            gpp:units = "g m-2 day-1" ;

I'm wondering if this is what is causing the error. An example error is:

[DEBUG][3][WorkConfront][EcosystemRespiration/FLUXCOM][CLM50] Traceback (most recent call last): File "/glade/campaign/cesm/community/lmwg/diag/ILAMB/CODE/ilamb/bin/ilamb-run", line 561, in WorkConfront c.confront(m) File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/Confrontation.py", line 431, in confront obs, mod = self.stageData(m) File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/Confrontation.py", line 376, in stageData lons=None if obs.spatial else obs.lon, File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/ModelResult.py", line 345, in extractTimeSeries assert lats.shape == lons.shape AssertionError

nocollier commented 9 months ago

I ran into this problem and forgot to fix. I re-rendered this data to fix a nan/fill value issue and in the process messed up the dimensions. Xarray and future Ilamb won’t care but old ilamb expects dimensions in a given order.

On Sat, Feb 24, 2024 at 1:38 PM Keith Oleson @.***> wrote:

I'm getting errors associated with new versions of FLUXCOM/reco.nc and FLUXCOM/gpp.nc datasets. I see that the reco and gpp variables in these files are ordered (lat,lon,time) instead of (time,lat,lon), e.g.,

float gpp(lat, lon, time) ;
        gpp:_FillValue = nanf ;
        gpp:long_name = "GPP" ;
        gpp:units = "g m-2 day-1" ;

I'm wondering if this is what is causing the error. An example error is:

[DEBUG][3][WorkConfront][EcosystemRespiration/FLUXCOM][CLM50] Traceback (most recent call last): File "/glade/campaign/cesm/community/lmwg/diag/ILAMB/CODE/ilamb/bin/ilamb-run", line 561, in WorkConfront c.confront(m) File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/Confrontation.py", line 431, in confront obs, mod = self.stageData(m) File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/Confrontation.py", line 376, in stageData lons=None if obs.spatial else obs.lon, File "/glade/work/oleson/conda-envs/ilamb_casper_lmwg/lib/python3.7/site-packages/ILAMB/ModelResult.py", line 345, in extractTimeSeries assert lats.shape == lons.shape AssertionError

— Reply to this email directly, view it on GitHub https://github.com/rubisco-sfa/ILAMB/issues/89, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFCB5GFGM7P6EF7HLKJJ3YVIXQ5AVCNFSM6AAAAABDYGMJL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TENBTHAZDGNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

evasinha commented 7 months ago

@nocollier I am getting the same error described above. I am using ILAMB version 2.7. How can I resolve this error?

nocollier commented 7 months ago

I just need to fix it, will do now. Stay tuned.

On Tue, Apr 9, 2024 at 2:21 PM Eva Sinha @.***> wrote:

@nocollier https://github.com/nocollier I am getting the same error described above. I am using ILAMB version 2.7. How can I resolve this error?

— Reply to this email directly, view it on GitHub https://github.com/rubisco-sfa/ILAMB/issues/89#issuecomment-2045826045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFCB2CDE3H4QASPWAEVRDY4QWSFAVCNFSM6AAAAABDYGMJL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVHAZDMMBUGU . You are receiving this because you were mentioned.Message ID: @.***>

nocollier commented 7 months ago

Can you try rerunning ilamb-fetch and checking if the new file resolves the issue? It looks good on my end.

Nate

On Tue, Apr 9, 2024 at 2:26 PM Nathan Collier @.***> wrote:

I just need to fix it, will do now. Stay tuned.

On Tue, Apr 9, 2024 at 2:21 PM Eva Sinha @.***> wrote:

@nocollier https://github.com/nocollier I am getting the same error described above. I am using ILAMB version 2.7. How can I resolve this error?

— Reply to this email directly, view it on GitHub https://github.com/rubisco-sfa/ILAMB/issues/89#issuecomment-2045826045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFCB2CDE3H4QASPWAEVRDY4QWSFAVCNFSM6AAAAABDYGMJL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVHAZDMMBUGU . You are receiving this because you were mentioned.Message ID: @.***>

evasinha commented 7 months ago

@nocollier I ran ilamb-fetch in the DATA folder . This updated a bunch of files. But when I run ILAMB, I still get the assert lats.shape == lons.shape AssertionError.

evasinha commented 7 months ago

I ran the ilamb-fetch again and this time it found four updated files related to FLUXCOM. I guess for some reason in the previous ilamb-fetch those updated files were not detected.

evasinha commented 7 months ago

@nocollier the updated/new FLUXCOM files have resolved the issue. Thanks for updating the data files.