rubjo / victor-mono-font

Repo for including Victor Mono in Google Fonts. Slight differences and adjustments to pass GF tests.
SIL Open Font License 1.1
9 stars 1 forks source link

soft dotted in fixed in Roman but not in italic #4

Closed RosaWagner closed 1 year ago

RosaWagner commented 1 year ago

Somehow you fixed the soft dotted feature in the upright font ;) In the italic, you just need to add a top anchor to dotless i, dotless j and update/compile the features.

rubjo commented 1 year ago

This is weird.

I did some other changes, so maybe it's OK now, I don't know :)

RosaWagner commented 1 year ago

ok let's roll then, tell me when there is a new release

rubjo commented 1 year ago

As in I should make a new release before you go further? The current release has the most recent binaries uploaded manually. Maybe I need to do a new release with a new tag in order for the binaries to be automatically attached?

RosaWagner commented 1 year ago

I don't know, but you can try :) Tell me if it works, I never tried this feature of the ghaction.

rubjo commented 1 year ago

Yep, bumping the release version by 0.001 worked: action auto-attached new binaries.