rubjo / victor-mono-font

Repo for including Victor Mono in Google Fonts. Slight differences and adjustments to pass GF tests.
SIL Open Font License 1.1
9 stars 1 forks source link

Fix Powerline glyphs #7

Closed Finii closed 1 year ago

Finii commented 1 year ago

[why]
The Powerline glyphs protrude noticeable down into the next line.

The reason is that the lowest point of that glyphs is at -340 while the descenders is only set to -250. The ascenders and descenders is used by terminals to determine baseline to baseline distance (together with the gap, sometimes, which is zero in this font).

[how]
Move the bottom and middle points of the Powerline glyphs E0B0 E0B1 E0B2 E0B3

The top point has an overshoot of 10 (line top is at 1100, top point coordinate is at 1110), so kept the same amount of overshoot for the bottom point: line bottom is at -250, bottom point should be a -260.

Bottom:

-340 -> -260
-291 -> -211    (same distance up)

Middle:

 385 ->  425    (half the distance to keep centered)

[note]
Did the changes in Glyph3 but commited only the basic changes while keeping the version number in the glyphs file.

Fixes: https://github.com/rubjo/victor-mono/issues/155

Finii commented 1 year ago

Uups, you already merged :-)

This is just the source change, I did not build anything.

Here a screenshot of intermediate stage (one master changed, one unchanged):

Screenshot 2023-07-12 at 12 05 55