search

rubjo / victor-mono

A free programming font with cursive italics and ligatures. Donations welcome ❤️
https://rubjo.github.io/victor-mono
SIL Open Font License 1.1
3.34k stars 44 forks source link

"fi" and "fl" ligatures render incorrectly in MacVim #27

Closed zatchheems closed 5 years ago

zatchheems commented 5 years ago

Background

hello! since switching from terminal Vim to MacVim, I've noticed that fl and fi render improperly, making text such as fixme, fluid, and config illegible and messing up the rest of the line.

within MacVim, a similar issue has been raised for a different font, albeit for different characters: https://github.com/macvim-dev/macvim/issues/841

I have been unable to replicate this issue with any other font on my machine that uses ligatures, so I'm curious as to whether this is not a MacVim-specific rendering problem, whether similar behavior can be replicated, and whether this is the correct place to make note of it.

given the discussion on whether the ligatures in question should be included at all, this issue slightly relates to: https://github.com/rubjo/victor-mono/issues/1

thanks!

Screenshots

set macligatures

image

set nomacligatures

image

rubjo commented 5 years ago

Kudos for being one of the Vim people! Every time I try a derivative, I think "gee, I'll have to use a year to learn how to get productive using this". 😆

MacVim has problems drawing more of this font's ligatures, it seems (eg. >= and <=).

It will probably work better if I change the way ligatures are set up. At the moment, I don't have an ETA on this.

zatchheems commented 5 years ago

thanks for getting back to this so quickly! I figured this had more to do with MacVim than anything given that everything renders hunky-dory in iTerm2:

image

I can live with it for now. cheers!

rubjo commented 5 years ago

Cool, iTerm2 is what I use as well. Leaving issue open and retesting with MacVim after next release.