Font not working on VS Code for mac

sohilkaushal commented 5 years ago

Hey,

I just updated my Mac and the font stopped working all together. As of now I have tried the following:

reinstall the font
reinstall VSCode
reset my machine( I had to do it anyway because Catalina update broke some of my other utilities as well).

I don't know if this is something because of Homebrew. So, it would be great if you could look into it.

Cherrs,

Sohil

rubjo commented 5 years ago

Hi Sohil!

That’s strange.

Does Homebrew install the font and make it available in other apps?
Do other fonts install correctly using Homebrew?
Are VS Code preferences set to use the font?
Do other fonts appear correctly in VS Code?

sohilkaushal commented 5 years ago

Hey @rubjo ,

So I just checked it out.

The font is now installing in VSCode it was my stupid config that was causing the errors. However, I still don't understand how can I enable italics as depicted in the website.

Thanks in advance.

Sohil

rubjo commented 5 years ago

You need to install and switch to a theme which specifies that parts of your code should be set in italics. I’m guessing that if you flick through the list of themes VS Code ships with, some of them have this?

sohilkaushal commented 5 years ago

Hey,

I have tried a few themes however the cursive's don't seem to be triggering for some reason. Cheers Sohil

rubjo commented 5 years ago

I would check in Font Book if the font’s italic style is installed and not disabled for some reason.

sohilkaushal commented 5 years ago

I would check in Font Book if the font’s italic style is installed and not disabled for some reason.

I have checked the font book and verified that the font is installed further, I have tested the font in webstorm and it is working

rubjo commented 5 years ago

Not sure what's wrong here, italics work fine in VS Code on Catalina here. I'm using VS Code Insiders, if that matters.

What does your VS Code font settings look like? What does you Font Book entries for Victor Mono look like?

sohilkaushal commented 5 years ago

Hey mate,

here are the screenshots of my font book and VSCode Settings

{
  "extensions.autoCheckUpdates": true,
  "workbench.settings.editor": "json",
  "workbench.iconTheme": "material-icon-theme",
  "workbench.startupEditor": "none",
  "workbench.fontAliasing": "auto",
  "search.useIgnoreFiles": true,
  "zenMode.hideLineNumbers": false,
  "zenMode.hideActivityBar": false,
  "files.autoSave": "afterDelay",
  "files.autoSaveDelay": 1000,
  "files.simpleDialog.enable": true,
  "editor.smoothScrolling": true,
  "editor.formatOnPaste": true,
  "editor.wordWrap": "on",
  "editor.fontFamily": "Victor Mono",
  "editor.fontSize": 13,
  "editor.fontWeight": "500",
  "editor.fontLigatures": true,
  "editor.suggestSelection": "first",
  "editor.cursorSmoothCaretAnimation": true,
  "editor.cursorBlinking": "solid",
  "editor.renderIndentGuides": true,
  "editor.renderWhitespace": "boundary",
  "editor.copyWithSyntaxHighlighting": false,
  "editor.showFoldingControls": "mouseover",
  "editor.matchBrackets": false,
  "editor.tabSize": 2,
  "editor.rulers": [
    80,
  ],
  "breadcrumbs.enabled": true,
  "terminal.integrated.showExitAlert": false,
  "terminal.integrated.fontFamily": "Monoid HalfLoose",
  "terminal.integrated.fontSize": 11,
  "terminal.integrated.cursorBlinking": true,
  "terminal.integrated.cursorStyle": "line",
  "emmet.includeLanguages": {
    "javascript": "javascriptreact"
  },
  "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
  "npm.enableScriptExplorer": true,
  "npm.autoDetect": "on",
  "explorer.confirmDelete": false,
  "window.zoomLevel": 0,
  "editor.detectIndentation": false,
  "search.useGlobalIgnoreFiles": true,
  "[javascript]": {
    "editor.defaultFormatter": "vscode.typescript-language-features"
  },
  "explorer.confirmDragAndDrop": false,
  "editor.minimap.enabled": false,
}

rubjo commented 5 years ago

K, seems that there is something preventing the italic from being applied in VS Code unless editor.fontWeight is set to "600". Doesn't seem to happen on Windows. Will investigate this.

sohilkaushal commented 5 years ago

Cool that's good.

BTW I'll be happy to help

rubjo commented 5 years ago

The developer of the font editing software I use pointed out the obvious solution: uninstalling the seven oblique styles should make the italics work.

While testing and verifying that, I noticed another issue: Selecting weights 100-300 doesn't seem to make any difference in VS Code for me, even though they should correspond to the Thin and Extra Light weights. At least we have the italics sorted. 😄

sohilkaushal commented 5 years ago

That's cool.

Thanks for your help😃

stdavis commented 5 years ago

I had to manually uninstall all of the oblique styles also to get the cursive to work in VSCode on macOS (Catalina). Thanks for the tip, @rubjo. Seems like a hack but I'm happy that it's working.

rubjo commented 5 years ago

Yeah, hopefully they’ll get it sorted: https://github.com/microsoft/vscode/issues/82122

patrick12james commented 2 years ago

The developer of the font editing software I use pointed out the obvious solution: uninstalling the seven oblique styles should make the italics work.

While testing and verifying that, I noticed another issue: Selecting weights 100-300 doesn't seem to make any difference in VS Code for me, even though they should correspond to the Thin and Extra Light weights. At least we have the italics sorted. 😄

How or where would you uninstall the 7 oblique styles?

rubjo commented 2 years ago

Deleting the oblique font files from your fonts folder. What’s the problem, I think everything should be working out of the box with VS Code now?

patrick12james commented 2 years ago

Yeah, at first I didn't know where they were located then found and deleted them and it still didn't work so for some reason I had to copy this code: https://gist.github.com/mohokh67/63bd7d6fb1f2bb381e47cfb0478de071 and then got it going. Thanks for checking back

On Sun, Jan 23, 2022 at 9:50 PM rubjo @.***> wrote:

Deleting the oblique font files from your fonts folder. What’s the problem, I think everything should be working out of the box with VS Code now?

— Reply to this email directly, view it on GitHub https://github.com/rubjo/victor-mono/issues/47#issuecomment-1019743344, or unsubscribe https://github.com/notifications/unsubscribe-auth/APFM7TIXDXWV7IKS2VJPGH3UXTSARANCNFSM4I7KMIXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

PavanKumarCB commented 1 year ago

Hey,

I have tried a few themes however the cursive's don't seem to be triggering for some reason. Cheers Sohil

Heyy how do you enable the oblique text? I have selected Victor Mono oblique itself in my font book yet it doesnt seem to show up in VSCode

kenmcd commented 1 year ago

This issue should not have been closed. The fonts available in the v1.5.5 release here are badly broken. They are not going to work properly in many applications.

The easiest fix is to get the versions from Google Fonts. Those fonts have been fixed and should work properly. https://fonts.google.com/specimen/Victor+Mono

rubjo / victor-mono

Font not working on VS Code for mac #47