Closed desheikh closed 3 years ago
Totals | |
---|---|
Change from base Build 330803147: | 0.0% |
Covered Lines: | 131 |
Relevant Lines: | 131 |
@bbatsov would you be able to review this?
Gentle bump. @koic perhaps if you are able?
Also registering interest for this simple but essential feature.
Yes, works great with spring to generate a binstub for rubocop so you can start executing it even faster.
I'd also like to just execute rubocop within guard for modified files only. Example cmd:
guard :rubocop, cmd: "git ls-files -m | xargs ls -1 2>/dev/null | grep '\.rb$' | xargs bin/rubocop" do
watch(%r{.+\.rb$})
watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
end
Ops, seems I had unwatched this repo by accident and didn't see the previous messages. Sorry about that!
This change looks good indeed, but should also be mentioned in the changelog and the README (otherwise it's unlikely that someone will find it).
Ops, seems I had unwatched this repo by accident and didn't see the previous messages. Sorry about that!
This change looks good indeed, but should also be mentioned in the changelog and the README (otherwise it's unlikely that someone will find it).
Thanks Team! I've updated the README.
Hmm, something's wrong with the CI build.
Looks like that issue is very intermittent from multiple posts to coveralls.
References:
Okay, I'll merge this and I'll cut a new release after we update the CI for Ruby 3.
Or I can update the CI over this weekend and cut a new release. (coverall's issue may be commented out as a workaround)
I've released v1.5.0. Thank you! https://github.com/rubocop/guard-rubocop/releases/tag/v1.5.0
Add a custom command option for when you want to use bundled or bin stubbed version of rubocop.