Changes run_on_changes to run_on_modifications

rubocop / guard-rubocop

Guard plugin for RuboCop

MIT License

262 stars 55 forks source link

Changes run_on_changes to run_on_modifications #6

Closed davejlong closed 10 years ago

davejlong commented 10 years ago

This fixes an issue with Vim where the task will run multiple times when a file is saved.

coveralls commented 10 years ago

Coverage decreased (-5.17%) when pulling 4d186f3a214d255b05c074070d91c6d1e8c1d8d5 on davejlong:patch-1 into b498bd2ee7d97a5ebeea91892ea8878b743bcb68 on yujinakayama:master.

coveralls commented 10 years ago

Coverage remained the same when pulling a10e1a457aa4c6164da9b7bd67cc00b907ce9d0e on davejlong:patch-1 into b498bd2ee7d97a5ebeea91892ea8878b743bcb68 on yujinakayama:master.

yujinakayama commented 10 years ago

Thanks for the PR, but there are a few concerns:

I'm not sure whether this implementation is a right way, because the reason why guard-rubocop runs multiple times with your Vim is still unclear.
With this change, guard-rubocop won't run on creation of a new file.

killphi commented 10 years ago

guard/guard#495 as to why run_on_modifications is better suited for certain editors

and for your second point, may I direct you to the Guard Wiki If I understand run_on_additions correctly, it would solve the second concern

cheers

yujinakayama commented 10 years ago

@killphi Thanks for the information. I'll handle it.

killphi commented 10 years ago

Thanks for considering it. I could've spared me some work, if I'd just looked at the pull requests beforehand :)

yujinakayama commented 10 years ago

Released 1.0.1.