search

rubocop / minitest-style-guide

Best practices for writing your tests
https://minitest.rubystyle.guide
70 stars 15 forks source link

Use `==` method instead of `eql?` method for "Refute Equal" rule #20

Closed koic closed 5 years ago

koic commented 5 years ago

refute_equal method uses == method, not eql? method. https://github.com/seattlerb/minitest/blob/15ed8e4/lib/minitest/assertions.rb#L587-L592

== method and eql? method behave differently.

This PR will remove eql? method to maintain compatibility for bad case and good case behavior.

duduribeiro commented 5 years ago

awesome 👍

🥇

bbatsov commented 5 years ago

Thanks!