search

rubocop / rails-style-guide

A community-driven Ruby on Rails style guide
http://rails.rubystyle.guide
6.48k stars 1.06k forks source link

Remove an incorrect comment for `find_by` example #265

Closed koic closed 4 years ago

koic commented 4 years ago

Dynamic finder methods (DynamicMatchers) has not been previously deprecated. AFAIK, Rails 6.0 has also no plans to deprecate it. https://github.com/rails/rails/blob/v6.0.3.2/activerecord/lib/active_record/dynamic_matchers.rb

So, it seems that this was written incorrectly when I refer to the following.

Therefore this PR removes the incorrect example comment for find_by.

pirj commented 4 years ago

Nice catch, thanks!