rubocop / rails-style-guide

A community-driven Ruby on Rails style guide
http://rails.rubystyle.guide
6.48k stars 1.06k forks source link

Prefer appending to setting `ignored_columns` #301

Closed fsateler closed 2 years ago

fsateler commented 2 years ago

Setting may overwrite previous assignments and that is almost always a mistake.

See also https://github.com/rubocop/rubocop-rails/pull/514

pirj commented 2 years ago

@rubocop/style-guide-editors Ping

pirj commented 2 years ago

To be fair, the only project where this technique is used in the wild is GitLab

fsateler commented 2 years ago

Thanks!