search

rubocop / rails-style-guide

A community-driven Ruby on Rails style guide
http://rails.rubystyle.guide
6.48k stars 1.06k forks source link

Add note to redundant-all section about `all` receiver being an association #348

Closed masato-bkn closed 1 year ago

masato-bkn commented 1 year ago

As pointed out https://github.com/rubocop/rails-style-guide/issues/347, when the receiver of all is an association, there are methods whose behavior changes when all is omitted.

So, I've added a note to caution against omitting these methods.

koic commented 1 year ago

This looks good. Can you squash your commits into one?

FYI, in reality, as a reviewer wanting to see the differences, it's sufficient to check using "Compare" link, so there's no need to commits as a work log :-)

masato-bkn commented 1 year ago

Thank you all for your reviews! I have squashed the commits, so please check it.

koic commented 1 year ago

Thanks!