rubocop / rubocop-ast

RuboCop's AST extensions and NodePattern functionality
https://docs.rubocop.org/rubocop-ast
MIT License
104 stars 52 forks source link

Fix a build error #280

Closed koic closed 8 months ago

koic commented 8 months ago

This PR resolves the following CI error with RuboCop 1.35.0:

  1) RuboCop Project requiring all of `lib` with verbose warnings enabled emits no warnings
     Failure/Error: expect(warnings).to eq []

       expected: []
            got: ["/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6:
warning: base64 wa...l no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.\n"]

       (compared using ==)

       Diff:
       @@ -1 +1,2 @@
       +/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6: warning:
base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
Add base64 to your Gemfile or gemspec.\n

     # ./spec/project_spec.rb:284:in `block (3 levels) in <top (required)>'

https://github.com/rubocop/rubocop-ast/actions/runs/8033104014/job/21943241393

It updates RuboCop to 1.57.2, which was finally resolved by https://github.com/rubocop/rubocop/pull/12313.

marcandre commented 8 months ago

Great, thank you ❤️