node.values.each is recommended by Style/HashEachMethods cop to be replaced with each_value instead of values.each. And node.each_value do |value| is clearer in intent than node.children.each do |value|.
Since it is a soft deprecation in documentation only, it has not been added to the changelog.
marcandre
commented
5 months ago
This PR lifts the deprecation from
ArrayNode#each_valuefor the following reasons:HashNode#each_valueandHashNode#each_keyare not deprecated.HashNode#each_value... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L76-L89HashNode#each_key... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L52-L65node.values.eachis recommended byStyle/HashEachMethodscop to be replaced witheach_valueinstead ofvalues.each. Andnode.each_value do |value|is clearer in intent thannode.children.each do |value|.Since it is a soft deprecation in documentation only, it has not been added to the changelog.