search

rubocop / rubocop-ast

RuboCop's AST extensions and NodePattern functionality
https://docs.rubocop.org/rubocop-ast
MIT License
104 stars 52 forks source link

Remove `Range#minmax` refinement #307

Closed Earlopain closed 2 months ago

Earlopain commented 2 months ago

It was added for a bug in Ruby < 2.7 The minimum version now is 2.7 so it is not needed anymore.

Context in https://github.com/rubocop/rubocop-ast/pull/151 and https://github.com/rubocop/rubocop-ast/pull/150

irb(main):001:0> RUBY_VERSION
=> "2.6.10"
irb(main):002:0> Range.instance_method(:minmax).owner != ::Range
=> true

irb(main):002> RUBY_VERSION
=> "2.7.8"
irb(main):003> Range.instance_method(:minmax).owner != ::Range
=> false
koic commented 2 months ago

Thanks!