Closed ydah closed 3 weeks ago
So we have to eat our own dogfood? Does this make sense? We have no capybara code here. I imagine the same will hit rubocop-minitest and rubocop-md, and rubocop-factory_bot, and other. It’s for rubocop itself and rubocop-rspec where this makes sense.
It’s an internal cop, shouldn’t it be looking in config/default.yml for this? Is it possible to fix the cop instead?
Sounds reasonable, I openend https://github.com/rubocop/rubocop/pull/13141 which would make this PR unnessesary. Let me know if something in that PR looks strange. It does indeed affect rubocop-factory_bot
as well.
This PR fixes a rubocop offense for
InternalAffairs/UndefinedConfig
Before submitting the PR make sure the following are checked:
main
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).