Fix an incorrect autocorrect for `Capybara/CurrentPathExpectation` when matcher's argument is a method with a argument and no parentheses

rubocop / rubocop-capybara

Code style checking for Capybara files.

https://docs.rubocop.org/rubocop-capybara

MIT License

40 stars 8 forks source link

Fix an incorrect autocorrect for `Capybara/CurrentPathExpectation` when matcher's argument is a method with a argument and no parentheses #39

Closed ydah closed 1 year ago

ydah commented 1 year ago

Fix: https://github.com/rubocop/rubocop-capybara/issues/37

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with main (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[-] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

ydah commented 1 year ago

Oh, the GHA workflow in Yamllint is not running 🤔

ydah commented 1 year ago

@bquorning @pirj @Darhazer Perhaps re-configuring the workflow settings from the required status checks might solve the problem. Can someone please reconfigure Yamllint as I don't seem to have the authority to change it?

スクリーンショット 2023-04-14 0 37 00

Something similar was happening:. https://github.com/rubocop/rubocop/pull/11714#issuecomment-1476204227

bquorning commented 1 year ago

Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesn’t work well on required checks.

So should we make the linter checks not required, or somehow make them “successful” if they are not run?

ydah commented 1 year ago

Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesn’t work well on required checks.

So should we make the linter checks not required, or somehow make them “successful” if they are not run?

Ah! Indeed it is 😱 Sorry, I overlooked the case where the merge was blocked. It does not seem possible to assume success if it is not executed, so it would be better to set it to not required or to stop the control by paths.