Closed ydah closed 1 year ago
Oh, the GHA workflow in Yamllint is not running đ€
@bquorning @pirj @Darhazer Perhaps re-configuring the workflow settings from the required status checks might solve the problem. Can someone please reconfigure Yamllint as I don't seem to have the authority to change it?
Something similar was happening:. https://github.com/rubocop/rubocop/pull/11714#issuecomment-1476204227
Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesnât work well on required checks.
So should we make the linter checks not required, or somehow make them âsuccessfulâ if they are not run?
Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesnât work well on required checks.
So should we make the linter checks not required, or somehow make them âsuccessfulâ if they are not run?
Ah! Indeed it is đ± Sorry, I overlooked the case where the merge was blocked.
It does not seem possible to assume success if it is not executed, so it would be better to set it to not required or to stop the control by paths
.
Fix: https://github.com/rubocop/rubocop-capybara/issues/37
Before submitting the PR make sure the following are checked:
main
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).