Closed ydah closed 8 months ago
Can you please run this against real-world-rspec?
Why don’t we make a GitHub Action that tests the branch against real-world-rspec, e.g. when a certain label is added to the PR?
It breaks quite frequently. Primary branch naming changes, removed repos, renamed repos, etc. With submodules, it’s a pita to keep it up to date. I just have something checked out on my local. Checking out each time as a GHA would do would most certainly break often.
Apart from that, rubocop configs should be removed. And —only <cop>
sometimes failed, e.g. for rubocop-factory_girl and rubocop-capybara, where new cops don’t make their way to .rubocop.yml, only to config/defaults.yml
I ran it through RSpec on a large Rails app and it seemed to work fine:
❯ bundle exec rubocop --only Capybara/RedundantWithinFind -A
Inspecting 11985 files
(snip)
11985 files inspected, 347 offenses detected, 347 offenses corrected
Resolve: https://github.com/rubocop/rubocop-capybara/issues/75
Before submitting the PR make sure the following are checked:
main
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.VersionAdded: "<<next>>"
indefault/config.yml
.