Add `Capybara/AmbiguousClick` cop and make soft-deprecated `Capybara/ClickLinkOrButtonStyle` cop. If you want to use `EnforcedStyle: strict`, use `Capybara/AmbiguousClick` cop instead - Githubissues

rubocop / rubocop-capybara

Code style checking for Capybara files.

https://docs.rubocop.org/rubocop-capybara

MIT License

38 stars 7 forks source link

Add `Capybara/AmbiguousClick` cop and make soft-deprecated `Capybara/ClickLinkOrButtonStyle` cop. If you want to use `EnforcedStyle: strict`, use `Capybara/AmbiguousClick` cop instead #99

Closed ydah closed 1 month ago

ydah commented 6 months ago

Motivation: https://github.com/rubocop/rubocop-capybara/issues/81

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with main (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop is configured as Enabled: pending in config/default.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.
[x] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

[x] Set VersionChanged: "<<next>>" in config/default.yml.