search

rubocop / rubocop-emacs

An Emacs interface for RuboCop
128 stars 30 forks source link

Consider rubocop installed if bundled #20

Closed imtayadeway closed 7 years ago

imtayadeway commented 8 years ago

For those that vendorize their gems, the rubocop binary may not be on the exec path, even if it has been bundled. For such users, their check command will need to be bundle exec rubocop instead. This change will allow rubocop-emacs to proceed with using the bundled rubocop if rubocop is not found on the exec path.

Fixes https://github.com/bbatsov/rubocop-emacs/issues/17

imtayadeway commented 8 years ago

@bbatsov anything I can do to help move this along?

dotemacs commented 8 years ago

Hello, what's the status of this PR?

It would be great to see it merged so that rubocop package becomes useful yet again.

Thank you @imtayadeway & @bbatsov

dennissivia commented 8 years ago

I agree. Would be great if this issue was fixed.

imtayadeway commented 8 years ago

@dotemacs @scepticulous I'm currently waiting on feedback, but I understand that Mr @bbatsov is a busy man :). Would either of you care to review?

dotemacs commented 8 years ago

@imtayadeway this seem like a fine solution. I have no objections. I'd just like to see it merged in, instead of messing around with setting up quelpa in order to use your fork :)

imtayadeway commented 8 years ago

@bbatsov anything I can do to help move this along? :heart:

kbrock commented 7 years ago

Thanks @imtayadeway & @bbatsov

This looks great. Anything I can do to help this along?

To1ne commented 7 years ago

I would love to see this merged. So @bbatsov It's a new year, which means a new opportunity to get this merged! 🤞

bbatsov commented 7 years ago

Sorry about this. I've been super busy and simply didn't see the comments here. It's always a good idea to ping me aggressively if something's dragging on. :-)

imtayadeway commented 7 years ago

:heart: :heart: :heart: