search

rubocop / rubocop-md

RuboCop for Markdown code snippets
MIT License
71 stars 14 forks source link

UPDATE rubocop version #12

Closed sfeuga closed 3 years ago

sfeuga commented 3 years ago

When using rubocop 1.1.0 version, running rubocop -r "rubocop-md" raise Unable to activate rubocop-md-0.3.2, because rubocop-1.1.0 conflicts with rubocop (~> 0.60) error.

According to the gem documentation I propose to update the version of rubocop in the rubocop-md.gemspec file.

All rake test pass, tested on Fedora 32 with ruby --version ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux].

sfeuga commented 3 years ago

@palkan beside question, where is the 0.4.0 version ? Because, on this repo we only have the 0.3.2 version.

ssnickolay commented 3 years ago

@sfeuga could you please fix the CI build? It seems we need to change just one line of code to fit the new Rubocop rules. Regarding v0.4.0 - I believe it was not released because this version contains only one not important feature https://github.com/rubocop-hq/rubocop-md/commit/1a8004a55955d8304987de5638c3f5199fa76dfa#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR5

sfeuga commented 3 years ago

@palkan For the v0.4.0 it's strange, it's available on rubygem.org.

~I'll fix the CI later today.~ Done.

palkan commented 3 years ago

For the v0.4.0 it's strange

I forgot to push the commit with the version.rb change; my bad(

palkan commented 3 years ago

Thanks! Released in 0.4.1