Follow up to #290 / #289 - I realised when re-reviewing my change that assertion_method? only checks the immediate expression of assignments, which makes sense for what it's meant to be doing - so we need to still handle checking the bodies of blocks for assignments.
I've not added a changelog for this since the original PR has not been released so I figured it would still be considered a single "fix", but let me know if you'd still like a second changelog entry anyway.
Before submitting the PR make sure the following are checked:
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
koic
commented
11 months ago
Follow up to #290 / #289 - I realised when re-reviewing my change that
assertion_method?only checks the immediate expression of assignments, which makes sense for what it's meant to be doing - so we need to still handle checking the bodies of blocks for assignments.I've not added a changelog for this since the original PR has not been released so I figured it would still be considered a single "fix", but let me know if you'd still like a second changelog entry anyway.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.