rubocop / rubocop-minitest

Code style checking for Minitest files.
https://docs.rubocop.org/rubocop-minitest
MIT License
144 stars 44 forks source link

Don't use `test-queue` to run tests on JRuby because it doesn't support `fork` #296

Closed G-Rath closed 11 months ago

G-Rath commented 11 months ago

Follow up to #294

Currently this is aimed at being the most straightforward if probably slightly inelegant way to get tests running on JRuby - I assume there is probably a slightly cleaner way of invoking tests but I don't yet know what it is and Rake::TestTask was more than a few lines of code 😅

I think it would be worth considering having test-queue "support" JRuby by not using fork if that platform is detected or if you set TEST_QUEUE_WORKERS to 1 (or maybe 0?) as a way of making it easier to have a normalized way of invoking tests across different platforms like this; but it would also be equally valid I think for test-queue to say that's out of scope for the gem🤷


Before submitting the PR make sure the following are checked:

koic commented 11 months ago

Thanks!