rubocop / rubocop-minitest

Code style checking for Minitest files.
https://docs.rubocop.org/rubocop-minitest
MIT License
144 stars 44 forks source link

Replace `EnsureNode.body` with `EnsureNode.branch` #324

Open dvandersluis opened 3 weeks ago

dvandersluis commented 3 weeks ago

EnsureNode.body has been deprecated in rubocop/rubocop-ast#337, and will be reimplemented in the next major version of rubocop-ast. In order to prepare for that, existing EnsureNode.body calls, which retreive the ensure branch of exception handling, have been replaced with EnsureNode.branch.


Before submitting the PR make sure the following are checked:

dvandersluis commented 3 weeks ago

There appears to be an unrelated test failure:

  1) Failure:
MultipleAssertionsTest#test_all_types_of_assignments_are_understood [test/rubocop/cop/minitest/multiple_assertions_test.rb:131]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
 "class FooTest < Minitest::Test
   def test_all_types_of_assignment
-  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [8/1].
+  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [9/1].
     # lvasgn
     foo = assert_equal(1, 1)
     # ivasgn

I opened #325 to fix it.