Open dvandersluis opened 3 weeks ago
There appears to be an unrelated test failure:
1) Failure:
MultipleAssertionsTest#test_all_types_of_assignments_are_understood [test/rubocop/cop/minitest/multiple_assertions_test.rb:131]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
"class FooTest < Minitest::Test
def test_all_types_of_assignment
- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [8/1].
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [9/1].
# lvasgn
foo = assert_equal(1, 1)
# ivasgn
I opened #325 to fix it.
EnsureNode.body
has been deprecated in rubocop/rubocop-ast#337, and will be reimplemented in the next major version of rubocop-ast. In order to prepare for that, existingEnsureNode.body
calls, which retreive theensure
branch of exception handling, have been replaced withEnsureNode.branch
.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.