rubocop / rubocop-performance

An extension of RuboCop focused on code performance checks.
https://docs.rubocop.org/rubocop-performance
MIT License
682 stars 80 forks source link

Fix DoubleStartEndWith example #419

Closed catlee closed 10 months ago

catlee commented 10 months ago

The example code for the DoubleStartEndWith is missing the # bad header for the first section here: https://docs.rubocop.org/rubocop-performance/cops_performance.html#includeactivesupportaliases-false-default

This PR adds the appropriate comments for this example.

Before submitting the PR make sure the following are checked:

koic commented 10 months ago

This seems to be an expected behavior of IncludeActiveSupportAliases: false. Accepting the changes in this PR would make IncludeActiveSupportAliases: false and IncludeActiveSupportAliases: true behave the same.