In Prism (Prism::Translation::Parser), match-with-lvasgn can be distinctly differentiated.
It is unclear whether to conform to the current behavior of the Parser gem, but initially, def_node_matcher has been updated to accept the following incompatibilities for Performance/EndWith, Performance/StringInclude, and Performance/StartWith cops to ensure it works with Prism 0.24.0 as well.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
Follow up https://github.com/rubocop/rubocop-ast/pull/277
In Prism (
Prism::Translation::Parser
),match-with-lvasgn
can be distinctly differentiated.It is unclear whether to conform to the current behavior of the Parser gem, but initially,
def_node_matcher
has been updated to accept the following incompatibilities forPerformance/EndWith
,Performance/StringInclude
, andPerformance/StartWith
cops to ensure it works with Prism 0.24.0 as well.Parser gem
Returns an
match_with_lvasgn
node:Returns an
match_with_lvasgn
node:This lvar-injecting feature appears to have not been supported by Parser gem for a long time: https://github.com/whitequark/parser/issues/69#issuecomment-19506391
Prism
Returns an
send
node:Returns an
match_with_lvasgn
node:Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.