rubocop / rubocop-rails

A RuboCop extension focused on enforcing Rails best practices and coding conventions.
https://docs.rubocop.org/rubocop-rails
MIT License
821 stars 263 forks source link

Revert #1311 - false negatives for `Rails/ActionControllerFlashBeforeRender` #1344

Closed Earlopain closed 2 months ago

Earlopain commented 3 months ago

Relates to #1269.

This cop would need to do control flow analysis which it just doesn't do. RuboCop also has no mechanism for that.

So just reverting this for now to fix the newly introduces false positives. No "Fix" in the commit since the original problem from the issue still occurs.


Before submitting the PR make sure the following are checked:

koic commented 2 months ago

This looks good to me. Can you squash your commits into one?