This PR fixes Rails/CompactBlank to avoid reporting offense for filter in Ruby versions below 2.6.
This change is related to https://github.com/rubocop/rubocop-rails/pull/1359. Apologies for the confusion earlier, as I initially mixed up the runtime version with the analysis version when considering Rubocop's supported versions.
Additionally, since https://github.com/rubocop/rubocop-rails/pull/1359 is still unreleased, I am unsure whether this change should be added to the changelog. I would appreciate any feedback, including thoughts on other aspects of this PR.
Before submitting the PR make sure the following are checked:
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
* [ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
koic
commented
2 months ago
This PR fixes
Rails/CompactBlankto avoid reporting offense forfilterin Ruby versions below 2.6.This change is related to https://github.com/rubocop/rubocop-rails/pull/1359. Apologies for the confusion earlier, as I initially mixed up the runtime version with the analysis version when considering Rubocop's supported versions.
Rails/CompactBlankapplies to Rails 6.1 and above, where the required Ruby version is 2.5. However, sincefiltermethod was introduced in Ruby 2.6, usingfilterin environments running Ruby 2.5 may result in false positives.Additionally, since https://github.com/rubocop/rubocop-rails/pull/1359 is still unreleased, I am unsure whether this change should be added to the changelog. I would appreciate any feedback, including thoughts on other aspects of this PR.
Before submitting the PR make sure the following are checked:
* [ ] Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.* [] If this is a new cop, consider making a corresponding update to the [Rails Style Guide](https://github.com/rubocop/rails-style-guide).