New cop that detects `redirect_to '/'`

[anthony-robin]

Is your feature request related to a problem? Please describe.

I often see in projects code such as redirect_to '/', alert: 'Lorem ipsum' which is not the most elegant writing. IMO the Rails route helper root_path seems a better way to handle it instead of hardcoding /.

Describe the solution you'd like

I would like a cop that throw an offense on this above line and suggest a replacement to redirect_to root_path, alert: 'Lorem ispum':

# Flag an offense
def index
  redirect_to '/', alert: 'Lorem ipsum'
end

# Autocorrect it
def index
  redirect_to root_path, alert: 'Lorem ipsum'
end

What do you think about this idea ? Thank you :)

[andyw8]

Is there perhaps a more general rule here of not allowing redirect_to with a string literal?

[vlad-pisanov]

@andyw8 sometimes it's necessary to redirect_to 'https://some-other-website.com'

[andyw8]

True, so perhaps it should only allow a string if it's a full URL (i.e. beginning http).

[andyw8]

This is actually kind of related to https://github.com/rubocop/rubocop-rails/issues/856 but enforcing the opposite.

[koic]

@andyw8 Is the link #856 wrong?

[andyw8]

Yes! But I can't find the one I meant, I think it was about named routes in tests.

[andyw8]

Ah, this I think: https://github.com/rubocop/rails-style-guide/issues/328