rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
794 stars 272 forks source link

Use Rubygems Trusted Publishers to publish #1829

Closed ydah closed 3 months ago

ydah commented 4 months ago

Fix: https://github.com/rubocop/rubocop-rspec/issues/1827


Before submitting the PR make sure the following are checked:

bquorning commented 4 months ago

Ooh, maybe this workflow could also create a new GH Release after publishing a new version.

ydah commented 3 months ago

I updated this PR. How about this?

pirj commented 3 months ago

This is incredible! I’ve just been reading a story about xz-utils today, what they pushed as a release was different from the source code. I hope we reduce the possibility of this happening with such trusted publishing?

bquorning commented 3 months ago

After this PR is merged, #1859 will add automatic creation of GitHub releases with notes generated from the changelog. Less manual work for us 😅

Or @ydah if you prefer, feel free to cherry-pick my changes into this branch.

ydah commented 3 months ago

@bquorning Thank you 😄! Let's merge #1859. Then we will close this PR👍

bquorning commented 3 months ago

@ydah If you squash the two commits, we can merge this PR and I’ll rebase #1859.

bquorning commented 3 months ago

The final git push failed because of our branch protection rules: https://github.com/rubocop/rubocop-rspec/actions/runs/8561970997/job/23464311900

I don’t know if we can somehow override that.

ydah commented 3 months ago

Maybe, I think the solution is as follows.