Closed ydah closed 3 months ago
Ooh, maybe this workflow could also create a new GH Release after publishing a new version.
I updated this PR. How about this?
This is incredible! I’ve just been reading a story about xz-utils today, what they pushed as a release was different from the source code. I hope we reduce the possibility of this happening with such trusted publishing?
After this PR is merged, #1859 will add automatic creation of GitHub releases with notes generated from the changelog. Less manual work for us 😅
Or @ydah if you prefer, feel free to cherry-pick my changes into this branch.
@bquorning Thank you 😄! Let's merge #1859. Then we will close this PR👍
@ydah If you squash the two commits, we can merge this PR and I’ll rebase #1859.
The final git push
failed because of our branch protection rules: https://github.com/rubocop/rubocop-rspec/actions/runs/8561970997/job/23464311900
I don’t know if we can somehow override that.
Maybe, I think the solution is as follows.
Fix: https://github.com/rubocop/rubocop-rspec/issues/1827
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).