rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
805 stars 277 forks source link

Add test to ensure unsafe cops are properly configured #1842

Closed ydah closed 6 months ago

ydah commented 6 months ago

Follow up: https://github.com/rubocop/rubocop/commit/7cda5aedc5ccf24ce53bccdb258a9e4dbac3ec16


Before submitting the PR make sure the following are checked:

bquorning commented 6 months ago

I noticed that our specs are flaky, and git-bisect tells me it happened after this PR.

Here’s a minimal failing spec run:

bundle exec rspec './spec/project/default_config_spec.rb[1:8]' './spec/rubocop/rspec/description_extractor_spec.rb[1:1]' --seed=28987
ydah commented 6 months ago

@bquorning Thank you. I fixed it: https://github.com/rubocop/rubocop-rspec/pull/1855