rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
805 stars 277 forks source link

Improve release workflow #1869

Closed ydah closed 5 months ago

ydah commented 5 months ago

This PR improves the release workflow. It turns out that being able to push directly to the default branch is quite difficult. That's because if GitHub actions can push to a protected branch, all you have to do is code a workflow that creates a branch and pushes it to other branches, and any collaborator in the repository can push whatever code they want to any branch. https://github.com/orgs/community/discussions/25305#discussioncomment-3247401

That last one step might be a pain, but I think it's better to automate it to the point where you create a PR that switches back versions. After the release workflow, a PR is created that switches back, so we should just merge it.

Note that this requires the following settings to be checked on:


Before submitting the PR make sure the following are checked:

ydah commented 5 months ago

@bquorning I don't have permission, so please check if the following settings are checked ON.

bquorning commented 5 months ago

Yep, the setting is ON.