search

rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
794 stars 272 forks source link

Docs namespaces don't match the real ones #1874

Closed smcabrera closed 2 months ago

smcabrera commented 2 months ago

We're getting messages like this after a recent update

RSpec/Rails/HaveHttpStatus has the wrong namespace - replace it with RSpecRails/HaveHttpStatus

But we noticed that the docs continue to have the old namespace

https://docs.rubocop.org/rubocop-rspec/2.29/cops_rspec_rails.html#rspecrailshavehttpstatus

CleanShot 2024-05-01 at 16 49 44@2x

Seems like the docs need to be updated unless I'm misunderstanding something.

ydah commented 2 months ago

We get a warning, but the cop in the old namespace RSpec/Rails/HaveHttpStatus is still there. This is left for backward compatibility. Therefore, I believe the documentation should also continue to be kept until the next major version of the these cop is removed.

pirj commented 2 months ago

Just to confirm, are those warnings? Or does this break your rubocop runs?

Closing assuming the former.