search

rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
792 stars 272 forks source link

RuboCop::RSpec::Language::NodePattern was removed #1884

Closed bquorning closed 1 month ago

bquorning commented 1 month ago

Address rubocop-rspec_rails still having a dependency on RuboCop::RSpec::Language::NodePattern which we removed in d841fe4152d780e9fcbfdf0789dbb6a7a596ed1e. We should probably fix this before next release.

bquorning commented 1 month ago

cc @ydah

pirj commented 1 month ago

We would also need to bump the dependency to the fixed rubocop-rspec_rails version?

bquorning commented 1 month ago

We (rubocop-rspec) don’t have a runtime dependency on rubocop-rspec_rails anymore.

It seems that the issue in rubocop-rspec_rails is easy enough to fix – we can just remove the line with the require. But it needs to be on a version of rubocop-rspec which includes d841fe4152d780e9fcbfdf0789dbb6a7a596ed1e, which has not been released yet.

We can probably make a v3.0.0.pre quite soon, which would make it possible to at least open a PR on rubocop-rspec_rails.

Update: Here’s the PR.

bquorning commented 1 month ago

I think https://github.com/rubocop/rubocop-rspec_rails/pull/30 proves this issue is easily solvable. I’m closing this so it doesn’t block v3.0.