Consider if any cops should be renamed

[bquorning]

Now that the next major release draws closer, I think it’s time to consider whether all of our cops are properly named.

Previous to their v1.0.0, RuboCop did a massive cop rename (see rubocop/rubocop#6983, rubocop/rubocop#7077, rubocop/rubocop#7468) and I wonder if we ever truly went over our cop names. Just one example:

• RSpec/DuplicatedMetadata
• RSpec/EmptyMetadata
• RSpec/MetadataStyle
• RSpec/SortMetadata

These four cops all check metadata, but three are named FooMetadata and one is MetadataFoo. Should one or three (or zero) be renamed?

[bquorning]

cc @rubocop/rubocop-rspec

[pirj]

https://github.com/rubocop/rubocop/pull/10725 adds some formal rules for cop naming. Even though it’s been a while, I don’t think even our new cops follow those cop naming guidelines.

I’m just thinking if this is worth the hassle for our users to rename cops in their project .rubocop.yml files? And those poor souls who dared extracting .rubocop.yml into a shared repository, while updating versions out of sync.

It is the time for this rename. But I have doubts if it is worth it. But I admin I may have a bias against renaming just because I got used to the existing naming, or I feel that the effort may be more significant than we envision it.

[bquorning]

Gotcha, you are correct that renaming might cause more pain than joy among our users. But perhaps we should copy that section from development.adoc into our repository and think a little more about cop names before adding them? 😅

[pirj]

That makes sense. I also commit to extracting the guideline part in hope to merge it