Closed bquorning closed 1 month ago
Backport the addition of new cop RSpec/ExpectInLet added in #1885 from the main branch to the 2-x-stable branch.
RSpec/ExpectInLet
main
2-x-stable
We want to get as much feedback as possible on new cops before (eventually) enabling them when v3 is released.
Before submitting the PR make sure the following are checked:
CHANGELOG.md
bundle exec rake
If you have created a new cop:
config/default.yml
Enabled: pending
Enabled: true
.rubocop.yml
VersionAdded: "<<next>>"
default/config.yml
Now I get it why we needed the branch.
Backport the addition of new cop
RSpec/ExpectInLet
added in #1885 from themain
branch to the2-x-stable
branch.We want to get as much feedback as possible on new cops before (eventually) enabling them when v3 is released.
Before submitting the PR make sure the following are checked:
2-x-stable
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.Enabled: true
in.rubocop.yml
.VersionAdded: "<<next>>"
indefault/config.yml
.