Enable all pending cops

bquorning commented 1 month ago

Closes #1886

When a new cop is added, its state is pending. The only time we enable cops is when we make a major release. v3.0 is just around the corner, so now we enable the pending cops.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

bquorning commented 1 month ago

@ydah The Danger check failed, and I’m not sure why. Could you have a look, please?

bquorning commented 1 month ago

@Darhazer Any comments?

bquorning commented 1 month ago

Let’s remember https://metaredux.com/posts/2020/06/08/the-rubocop-name-drama-redux.html and not get too crazy with the police/cop analogy 😬

I asked @Darhazer for feedback only about an hour ago, so I’ll leave this PR open until tomorrow where I’ll merge and make a pre-release. See also https://github.com/rubocop/rubocop-rspec/discussions/1880#discussioncomment-9661623

pirj commented 1 month ago

I admit I had a few more funny phrases to add to that comment, but removed them before sending.

rubocop / rubocop-rspec

Enable all pending cops #1902