Private code should be private. I think this makes it easier to read and understand the code.
I am not sure if this is a code style we should enforce with a cop? We haven’t done so with the previous style, and yet it was uses consistently on all cops except two.
If we don’t have a cop to enforce this style, it’s something we need to be aware of when doing code review.
Before submitting the PR make sure the following are checked:
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Updated documentation.
[ ] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).
Private code should be private. I think this makes it easier to read and understand the code.
I am not sure if this is a code style we should enforce with a cop? We haven’t done so with the previous style, and yet it was uses consistently on all cops except two.
If we don’t have a cop to enforce this style, it’s something we need to be aware of when doing code review.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).