search

rubocop / rubocop-rspec

Code style checking for RSpec files.
https://docs.rubocop.org/rubocop-rspec
MIT License
792 stars 272 forks source link

Don't always define node patterns in private scope #1907

Closed bquorning closed 4 weeks ago

bquorning commented 4 weeks ago

Mostly a revert of #1906, based on arguments in this thread: https://github.com/rubocop/rubocop-rspec/pull/1906#discussion_r1629301489

The only thing not reverted is the change to .rubocop.yml.

bquorning commented 4 weeks ago

I want to try and make some of the node patterns private, but I’ll do it later in another pull request. Sorry for the noise.