search

rubocop / rubocop-sequel

Code style checking for Sequel
MIT License
28 stars 14 forks source link

Bump rubocop version to 1.0 #13

Closed rickselby closed 3 years ago

rickselby commented 3 years ago

Ref #12

rubocop-rspec is still tied to < 1.0; this should be reinstated once v2.0 is released. See rubocop-hq/rubocop-rspec#1055

All the tests still pass, so I hope this will still work...!

pirj commented 3 years ago

You may use rubocop-rspec 2.0.0.pre, but hopefully 2.0 will be out by Monday.

bquorning commented 3 years ago

RuboCop RSpec 2.0.0 has just been released. 🎉

wagenet commented 3 years ago

Can we get this updated and merged?

TSMMark commented 3 years ago

To be able to upgrade rubocop to 1.2.0 in our codebase, I forked and updated the gemspec manually and I don't get any errors if you need an immediate way to upgrade.

Not sure if the rubocop-sequel cops are working, I haven't tested them. But the rubocop version 1.2.0 upgrade worked and all the other cops seem to be working.

Take it or leave it!

gem "rubocop-sequel", require: false, github: "Vydia/rubocop-sequel", ref: "56cc4c679a5077b76f551182cc04c31440e33660"
rickselby commented 3 years ago

Updated as requested. Hopefully someone from @rubocop-hq can get this merged.

bquorning commented 3 years ago

@cyberdelia I think you’re the only one who has the permissions to push the new version to https://rubygems.org/gems/rubocop-sequel 🙏

rickselby commented 3 years ago

Is there anything more we can do to get this pushed?

cyberdelia commented 3 years ago

I just pushed 0.1.0: https://rubygems.org/gems/rubocop-sequel/versions/0.1.0 Happy to help anyone from @rubocop-hq/rubocop-core willing to automate the publication.

bbatsov commented 3 years ago

@cyberdelia You might make a few of us co-owners of the gem on RubyGems.

cyberdelia commented 3 years ago

I added you, @bbatsov.

bbatsov commented 3 years ago

Thanks!