search

rubocop / rubocop-sequel

Code style checking for Sequel
MIT License
28 stars 14 forks source link

fix add_offense positional args deprecation #2

Closed bgentry closed 7 years ago

bgentry commented 7 years ago

Fixes #1.

cyberdelia commented 7 years ago

@bgentry It might requires to bump the version of rubocop in the gemspec too.

Also hi 👋

bgentry commented 7 years ago

@cyberdelia added a version bump as well. Cheers✌️

bgentry commented 7 years ago

hmm apparently this is totally busted now, will work on it

cyberdelia commented 7 years ago

I removed the useless Gemfile.lock on master, so you might have to rebase too.

bgentry commented 7 years ago

so I fixed the specs and then ran rubocop locally to discover that there were a bunch of complaints. Not sure which were new to the version bump and which were pre-existing, but I did my best to fix all of them. Only this one remains which seems ridiculous to me:

➜  rubocop-sequel git:(master) ✗  rubocop -a
Inspecting 13 files
..........C..

Offenses:

spec/rubocop/cop/sequel/migration_name_spec.rb:3:1: C: Block has too many lines. [30/25]
describe RuboCop::Cop::Sequel::MigrationName, :config do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

13 files inspected, 1 offense detected

It's complaining about the length of the rspec block??

bgentry commented 7 years ago

also it wants rubocop-sequel.rb to be renamed to use snake case but I didn't think it was appropriate for me to do that.

cyberdelia commented 7 years ago

@bgentry Open another issue maybe?