rubrikinc / rubrik-scripts-for-powershell

Collection of PowerShell Scripts created to interact to Rubrik CDM
MIT License
50 stars 58 forks source link

Add ability in CollectSQLProfile.ps1 to read instances from a file #164

Closed jfroebe closed 3 years ago

jfroebe commented 4 years ago

Fixes #163

Description

Allows for supplying a csv file of Host/Instance pairs to avoid calling the CollectSQLProfile.ps1 in a loop.

Related Issue

This project only accepts pull requests related to open issues.

https://github.com/rubrikinc/rubrik-scripts-for-powershell/issues/163

Motivation and Context

If there are dozens, hundreds or more instances, the command line may exceed the maximum number of characters allowed. Using a csv file avoids this limit.

How Has This Been Tested?

Tested using 80+ instances on numerous on prem machines.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

clumnah commented 3 years ago

Hello, Do you have an example of what the CSV file should look like? I want to update documentation as well before I push this through. The script already accepts a comma separated list of server instances