Fix 2 issues - Githubissues

rubrikinc / rubrik-sdk-for-powershell

Rubrik Module for PowerShell

https://build.rubrik.com/sdks/powershell/

MIT License

102 stars 87 forks source link

Fix 2 issues #826

Closed tonypags closed 1 year ago

tonypags commented 1 year ago

PSv5 won't run this function because Invoke-RestMethod doesn't yet support SkipCertificateCheck. Changed logic to add this parameter conditionally.
The Session ID is not returned; null values are hard-coded. Added the value from the response to the hashtable.

Related Issue

https://github.com/rubrikinc/rubrik-sdk-for-powershell/issues/817
No issue exists

Motivation and Context

I am unable to run code in production using the current version.
I am unable to disconnect a specific session without its ID

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[x] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

tonypags commented 1 year ago

I've made minor changes which do not need changes to docs. I also added unit test for Service Account, which would have caught this issue (includes mock for invoke-restmethod).