rubrikinc / terraform-azure-polaris-cloud-native_subscription

MIT License
1 stars 2 forks source link

Updating to support latest Provider functions #6

Closed joeharlan closed 3 months ago

joeharlan commented 4 months ago

Description

This PR includes some changes in formatting for readability, but also include some functional changes. The main functional change includes code to support handling any empty role templates returned by the RSC API that the Azure RM provider interprets as a change on every plan/apply operation despite there being no actual changes.

Related Issue

This project only accepts pull requests related to open issues.

Please link to the issue here

Motivation and Context

The proposed changes solve the previously mentioned issue with the RG-scoped Azure SQL DB and Azure SQL MI role templates containing no permissions.

How Has This Been Tested?

The changes were tested in the Oasis Labs environment using the 0.9.0-beta.8 polaris Provider.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

joeharlan commented 4 months ago

@DamaniN Reverted to previous name. Though I have to ask, is it common to use module examples as-is, or is it more common to clone them to your own repo and modify as desired?