search

rubrikinc / terraform-provider-polaris

Terraform provider for the Polaris platform
MIT License
2 stars 9 forks source link

Rename the subscription_id field for polaris_azure_exocompute #87

Closed DamaniN closed 2 months ago

DamaniN commented 9 months ago

Is your feature request related to a problem? Please describe.

Having a field called subscription_id in the polaris_azure_exocompute resource is confusing. There is a subscription_id field in the polaris_azure_subscription resource which refers to the Azure Subscription ID. The subscription_id field in the polaris_azure_exocompute actually refers to the RSC/Polaris native ID for the polaris_azure_subscription resource. This is an entirely different ID.

Also, the current docs don't explain the subscription_id field in the polaris_azure_exocompute resource very well.

Describe the solution you'd like

  1. Deprecate the subscription_id field in the polaris_azure_exocompute resource and replace it with a field called something like polaris_subscription_id.
  2. Update the documentation for the polaris_azure_exocompute resource to make it clearer that this is not the Azure subscription ID but the RSC/Polaris native ID.

Describe alternatives you've considered

None

Additional context

This confusion caused me to keep putting the wrong ID in the field. I had to work with the provider developer to figure out what the issue was.

johan3141592 commented 2 months ago

@DamaniN this has been improved in the latest beta release (v0.9.0-beta.1). The subscription_id field has been deprecated and a new field called cloud_account_id has been introduced, this follows the API naming scheme. Please see https://registry.terraform.io/providers/rubrikinc/polaris/latest/docs/resources/azure_exocompute and https://registry.terraform.io/providers/rubrikinc/polaris/latest/docs/guides/upgrade_guide_beta for details.