search

ruby-amqp / amq-protocol

AMQP 0.9.1 protocol serialization and deserialization implementation for Ruby (2.0+)
http://groups.google.com/group/ruby-amqp
MIT License
48 stars 31 forks source link

fixed single bite conversion from signed to unsigned for 'b' frames #41

Closed ghost closed 10 years ago

ghost commented 10 years ago

A fix regarding issue #40

michaelklishin commented 10 years ago

OK, I had to revert this. Please make sure all tests pass and CI does not fail.

ghost commented 10 years ago

Sorry about that Michael, I've now made sure that all the tests pass. (changed the decode_short_short test to decode_byte)

michaelklishin commented 10 years ago

I still get a failure:

1.9.x-stable* be rspec spec/
zsh: correct 'rspec' to 'spec' [nyae]? n
Running on 2.0.0
..............................................................................................................................................................................................................F............................................................................................................................................................................................................

Failures:

  1) AMQ::Protocol::Table.decode is capable of decoding 8bit unsigned integers
     Failure/Error: output = TableValueDecoder.decode_byte("\xC0",0).first
     NoMethodError:
       undefined method `decode_byte' for AMQ::Protocol::TableValueDecoder:Class
     # ./spec/amq/protocol/table_spec.rb:179:in `block (3 levels) in <module:Protocol>'

Finished in 0.13812 seconds
411 examples, 1 failure
ghost commented 10 years ago

Ah, I think maybe it's isolated 215253accaccab42df1b640b1ea62d3136dd0560 as a cherry pick (as it never updated the changes to fix this bug in this pull request). It looks like github ignores changes on a branch after its been merged (even if it is rejected thereafter?). Should I drop this pull request and see it if picks up all the changes on a new pull request?

michaelklishin commented 10 years ago

Yes, just push another branch and submit it.