search

ruby-amqp / amq-protocol

AMQP 0.9.1 protocol serialization and deserialization implementation for Ruby (2.0+)
http://groups.google.com/group/ruby-amqp
MIT License
48 stars 31 forks source link

Serialisation of negative integers in headers #52

Closed michaelklishin closed 9 years ago

michaelklishin commented 9 years ago

Adding a negative integer to this spec example results in an underflow. This is because integer header values are serialised as unsigned.

They should be signed. Now that Bunny only supports Ruby 2.0+, this is easier because there are more Array#pack options that support network byte order.

michaelklishin commented 9 years ago

Fixed by #55.

michaelklishin commented 9 years ago

Note that this is a significant breaking change but it only affects headers. Thus the next release will be 2.0.0.